Code Review
From MediaWiki.org
For MediaWiki (recent comments | status | tags | authors | release notes)
 First page |
 Previous page |
 Next page |
 Last page |
| Date | Commenter | Revision | Status | Commit summary | Note |
|---|---|---|---|---|---|
| 13:03, 9 May 2009 | Catrope | 50366 | new | This also fixes the E_STRICT reported in bug 18730 comment #1 | |
| 11:39, 9 May 2009 | Nikerabbit | 49677 | fixme | This causes the following for one of translatewiki.net images: [09-May-2009 11:31:48] PHP Warning: Invalid argument supplied for foreach() in /var/www/w/includes/Exif.php on line 610 [times N] | |
| 09:17, 9 May 2009 | Siebrand | 49898 | fixme | Suggest to make use of this message again, as it is unused at the moment, and then revert, or mark this commit as OK. | |
| 14:35, 8 May 2009 | Aaron Schulz | 50331 | new | How many places is this stuff duplicated? | |
| 14:34, 8 May 2009 | Aaron Schulz | 49408 | fixme | I would have used normal checkboxes except the the entire page is already a form for diffs, wish makes it hard to submit to two differing locations (article url and revisiondelete url) | |
| 08:56, 8 May 2009 | IAlex | 50316 | fixme | fixed in r50330. | |
| 08:55, 8 May 2009 | IAlex | 50324 | resolved | fixed in r50330. | |
| 08:23, 8 May 2009 | Tim Starling | 48837 | fixme | Flawed (as per my comment on r49408) but better than what's live already so I'm deploying it. | |
| 08:18, 8 May 2009 | Tim Starling | 49408 | fixme | This style of UI easily be done without any JavaScript dependency. For instance, look at the Special:Undelete code. This is not acceptable as it is. | |
| 03:43, 8 May 2009 | Arash Boostani | 50245 | fixme | Thanks for the examples. I definitely see the issue. We're trying to decide the best way to move forward on this, which will probably take a couple of days, so I'll update this page with the plan. In the meantime, this functionality is off by default, so there shouldn't be any adverse effects. | |
| 23:03, 7 May 2009 | Aaron Schulz | 50316 | fixme | What script? I'm not getting that error. | |
| 22:52, 7 May 2009 | Brion VIBBER | 50316 | fixme | r50324 still leaves this: Fatal error: Call to undefined function wfProfileIn() in /Library/WebServer/Documents/trunk/includes/Setup.php on line 22 | |
| 18:36, 7 May 2009 | IAlex | 50316 | fixme | This broke maintenance scripts: Fatal error: require_once() [function.require]: Failed opening required 'StartProfiler.php' (include_path='.:/usr/lib/php') in maintenance/commandLine.inc on line 47 | |
| 23:35, 6 May 2009 | Simetrical | 50245 | fixme | The following wikitext: <pre><div> ==Foo== </div> abc ==Bar== </pre> produces output like the following (omitting the edit link and other garbage in the h2 for clarity): <pre><div> <div id="section_0_container"><h2>Foo</h2> </div> <p>abc </p> </div><div id="section_1_container"><h2>Bar</h2></div> </… | |
| 22:48, 6 May 2009 | Rainman | 50207 | fixme | The result count issue fixed in r50282. As for javascript toggle, yes, looks like a good idea, I'll add it to the rest of the JS I have planned. | |
| 18:28, 6 May 2009 | Arash Boostani | 50245 | fixme | I've tested both of the scenarios - a header within a manually entered div and a header within a table - and it works as expected. I agree that this can probably be done through DOM, but it would be slow for large and complex sections. I felt that doing it as the parser renders the output was the mo… | |
| 18:22, 6 May 2009 | Raymond | 50264 | reverted | Per above comment reverted in r50274 | |
| 16:49, 6 May 2009 | Aude | 50207 | fixme | If you want to try the advanced search on my demo, good keywords to try would be "art", "gallery", "museum", etc. | |
| 16:47, 6 May 2009 | Aude | 50207 | fixme | The new search interface looks good. Though, one thing that has long bothered me about the search page is having no toggle for mass selecting or deselecting all the namespace checkboxes when doing an "advanced" search. I know you can do that with the shift key, but it doesn't work ideally for me, … | |
| 15:57, 6 May 2009 | Jan Luca | 50264 | reverted | I don't know the extensions, too. Maybe see the autor this problem | |
| 15:46, 6 May 2009 | Simetrical | 50245 | fixme | Actually, I haven't tested this, but won't it create invalid XHTML in many cases? E.g., <pre><div> ==Section== </div></pre> There are likely to be many cases like this, where someone wants to mark up a header, or put headers inside tables, etc. I'm pretty sure I've seen implementations of this … | |
| 15:44, 6 May 2009 | Raymond | 50265 | reverted | Fixme per comment in r50264. | |
| 15:44, 6 May 2009 | Raymond | 50264 | reverted | Sorry, I have not seen the following in my first review. But wfMsgExt('datasearch_match_words_lang', array( 'parse' ) , $languageName, $searchText) and wfMsgExt('datasearch_match_words', array( 'parse' ) , $searchText) cannot work because $1 in the message is a text ($languageName / $searchText)… | |
| 15:35, 6 May 2009 | Jan Luca | 50264 | reverted | Fixed in r50265 | |
| 15:30, 6 May 2009 | Raymond | 50264 | reverted | * Why 'replaceafter'? * The English messages of the i18n file needs an update too. | |
| 15:14, 6 May 2009 | Arash Boostani | 50245 | fixme | Good point. Fixed in r50263. | |
| 14:53, 6 May 2009 | Catrope | 50259 | resolved | According to wfMsgExt()'s documentation, contradictory options such as parse and parsemag shouldn't be used together. | |
| 14:21, 6 May 2009 | Catrope | 50130 | fixme | Maybe not, but I'm not sure HTML is ideal either; also, if people really care they can always run the wikitext through action=parse | |
| 13:58, 6 May 2009 | Simetrical | 50245 | fixme | All new globals need to be initialized in DefaultSettings.php. Otherwise you can have register_globals vulnerabilities. Also, DefaultSettings.php is used for documentation: currently $wgSectionContainers isn't documented in any central place in the code. | |
| 08:53, 6 May 2009 | Rainman | 50208 | fixme | I've already updated the backend on all servers to the latest lucene-search version so it handles both the old and new way. So, server-wise this is ready to roll out. | |
| 08:30, 6 May 2009 | ThomasV | 50206 | fixme | fixed in 50253 | |
| 04:19, 6 May 2009 | Arash Boostani | 50245 | fixme | Yes, it's related. I fixed it in r50251. There function call was passing references, but not indicating them properly. | |
| 03:29, 6 May 2009 | Voice of All | 50245 | fixme | 'Warning: Call-time pass-by-reference has been deprecated in C:\WAMPServer\www\MW_alpha\includes\parser\Parser.php on line 3704' Related? | |
| 00:20, 6 May 2009 | Brion VIBBER | 50064 | ok | + $data['lang'] = $GLOBALS['wgLanguageCode']; ^ Shouldn't this be wgContLanguageCode? It's not new though, so no rush. :) | |
| 00:10, 6 May 2009 | Brion VIBBER | 50121 | ok | Perfect, thanks! :D | |
| 00:02, 6 May 2009 | Brion VIBBER | 50130 | fixme | This seems to be passing wikitext straight out... is that ideal formatting? | |
| 23:18, 5 May 2009 | Brion VIBBER | 50246 | ok | Fixup to r50245 | |
| 23:18, 5 May 2009 | Brion VIBBER | 50245 | fixme | In wrong dir; removed in r50246 | |
| 22:34, 5 May 2009 | Brion VIBBER | 50126 | resolved | Thanks! | |
| 22:13, 5 May 2009 | Brion VIBBER | 50187 | ok | Hit fixme by mistake, looks fine. :) | |
| 21:53, 5 May 2009 | ThomasV | 50206 | fixme | it looks like there were issues for early versions of firefox (earlier than 1.1) http://annevankesteren.nl/2004/09/overflow | |
| 21:44, 5 May 2009 | Brion VIBBER | 50207 | fixme | Looks great! One problem I noticed, using the default search backend... the total result count is wrong, giving the number of hits returned within our search limit -- eg: "Results 21 - 24 of 4 for the" for the second page of results for the word "the". | |
| 21:38, 5 May 2009 | Brion VIBBER | 50208 | fixme | Does this require a server-side update for the new parameter? If so we need to make sure updates are coordinated. | |
| 21:37, 5 May 2009 | Brion VIBBER | 50206 | fixme | IIRC overflow-x and overflow-y aren't universally supported. Any cross-browser issues? | |
| 21:24, 5 May 2009 | Brion VIBBER | 50127 | reverted | Reverted in r50240. This changes the default format from json to xmlfm, breaking anything which would have attempted to use standard json search suggestions, such as when $wgEnableMWSuggest is set. | |
| 13:07, 5 May 2009 | Tim Starling | 50132 | resolved | Defines are global and should be prefixed to avoid conflicts with PHP modules. I'll let it pass for unlikely names but "API" is a bit generic. | |
| 13:01, 5 May 2009 | Tim Starling | 49999 | ok | Can you explain the bug and provide a rationale for backporting? | |
| 12:53, 5 May 2009 | Tim Starling | 49151 | new | The bug is not severe enough for a backport. | |
| 11:09, 5 May 2009 | IAlex | 50192 | resolved | fixed in r50216. | |
| 09:48, 5 May 2009 | Catrope | 47473 | resolved | Done in r50215 |
First page |
Previous page |
Next page |
Last page |
